Re: 回复: [edk2-devel] [PATCH v1 1/1] Add MemoryFence implementation for RiscV64


Daniel Schaefer
 

It's not required to go into that tag.
We need two more patches that we haven't submitted yet to boot on Qemu.

Would it be okay if we used a library from ArmVirtPkg for RISCV64?
Or does it have to be moved to some other place first?


From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of gaoliming <gaoliming@...>
Sent: Friday, May 21, 2021 14:35
To: devel@edk2.groups.io <devel@edk2.groups.io>; Schaefer, Daniel <daniel.schaefer@...>
Cc: Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; 'Michael D Kinney' <michael.d.kinney@...>; 'Zhiguang Liu' <zhiguang.liu@...>; 'Leif Lindholm' <leif@...>
Subject: 回复: 回复: [edk2-devel] [PATCH v1 1/1] Add MemoryFence implementation for RiscV64
 

Daniel:

 Thanks for your information. Acked-by: Liming Gao <gaoliming@...>

 

  And, do you request to merge this patch for edk2 stable tag 202105?

  

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Daniel Schaefer
发送时间: 2021521 13:27
收件人: devel@edk2.groups.io; gaoliming@...
抄送: Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; 'Michael D Kinney' <michael.d.kinney@...>; 'Zhiguang Liu' <zhiguang.liu@...>; 'Leif Lindholm' <leif@...>
主题: Re: 回复: [edk2-devel] [PATCH v1 1/1] Add MemoryFence implementation for RiscV64

 

Great!

 

It is verified I can boot Linux from a virtio ESP using this patch on QEMU virt machine.

 

Thanks,

Daniel


From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of gaoliming <gaoliming@...>
Sent: Friday, May 21, 2021 13:14
To: devel@edk2.groups.io <devel@edk2.groups.io>; Schaefer, Daniel <daniel.schaefer@...>
Cc: Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; 'Michael D Kinney' <michael.d.kinney@...>; 'Zhiguang Liu' <zhiguang.liu@...>; 'Leif Lindholm' <leif@...>
Subject:
回复: 回复: [edk2-devel] [PATCH v1 1/1] Add MemoryFence implementation for RiscV64

 

Daniel:
  Now, it is clear to me. So, I suggest to merge this change when it is
verified on generic RISC-V QEMU virt machine. Is it OK?

Thanks
Liming
> -----
邮件原件-----
>
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Daniel
> Schaefer
>
发送时间: 2021518 10:35
>
收件人: devel@edk2.groups.io; gaoliming@...
>
抄送: 'Abner Chang' <abner.chang@...>; 'Michael D Kinney'
> <michael.d.kinney@...>; 'Zhiguang Liu' <zhiguang.liu@...>;
'Leif
> Lindholm' <leif@...>
>
主题: Re: 回复: [edk2-devel] [PATCH v1 1/1] Add MemoryFence
> implementation for RiscV64
>
> On 5/18/21 9:04 AM, gaoliming wrote:
> > Daniel:
> >  Seemly, this API is missing in BaseLib for RiscV64 arch. How do you
detect
> > this issue?
>
> What do you mean it's missing?
> Yes MemoryFence() for RiscV64 is missing currently, that's why I'm adding
it
> here.
>
> Maybe you mean that it's not currently used? That's also true.
> I'm enabling the generic QEMU virt machine (like OVMF or ArmVirtPkg) for
> RISC-V.
> At least QemuFwCfgLib and VirtioLib need it.
> That's why I have the need to add this implementation now.
>
> Does that clear it up?
>
> > Thanks
> > Liming
> >> -----
邮件原件-----
> >>
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Daniel
> >> Schaefer
> >>
发送时间: 2021516 2:13
> >>
收件人: devel@edk2.groups.io
> >>
抄送: Abner Chang <abner.chang@...>; Michael D Kinney
> >> <michael.d.kinney@...>; Liming Gao <gaoliming@...>;
> >> Zhiguang Liu <zhiguang.liu@...>; Leif Lindholm
<leif@...>
> >>
主题: [edk2-devel] [PATCH v1 1/1] Add MemoryFence implementation for
> >> RiscV64
> >>
> >> Cc: Abner Chang <abner.chang@...>
> >> Cc: Michael D Kinney <michael.d.kinney@...>
> >> Cc: Liming Gao <gaoliming@...>
> >> Cc: Zhiguang Liu <zhiguang.liu@...>
> >> Cc: Leif Lindholm <leif@...>
> >> Signed-off-by: Daniel Schaefer <daniel.schaefer@...>
> >> ---
> >>  MdePkg/Library/BaseLib/BaseLib.inf           |  1 +
> >>  MdePkg/Library/BaseLib/RiscV64/MemoryFence.S | 33
> >> ++++++++++++++++++++
> >>  2 files changed, 34 insertions(+)
> >>
> >> diff --git a/MdePkg/Library/BaseLib/BaseLib.inf
> >> b/MdePkg/Library/BaseLib/BaseLib.inf
> >> index b76f3af380ea..b7ab5f632366 100644
> >> --- a/MdePkg/Library/BaseLib/BaseLib.inf
> >> +++ b/MdePkg/Library/BaseLib/BaseLib.inf
> >> @@ -399,6 +399,7 @@
> >>    RiscV64/DisableInterrupts.c
> >>
> >>
> >>    RiscV64/EnableInterrupts.c
> >>
> >>
> >>    RiscV64/CpuPause.c
> >>
> >>
> >> +  RiscV64/MemoryFence.S             | GCC
> >>
> >>
> >>    RiscV64/RiscVSetJumpLongJump.S    | GCC
> >>
> >>
> >>    RiscV64/RiscVCpuBreakpoint.S      | GCC
> >>
> >>
> >>    RiscV64/RiscVCpuPause.S           | GCC
> >>
> >>
> >> diff --git a/MdePkg/Library/BaseLib/RiscV64/MemoryFence.S
> >> b/MdePkg/Library/BaseLib/RiscV64/MemoryFence.S
> >> new file mode 100644
> >> index 000000000000..283df9356a9a
> >> --- /dev/null
> >> +++ b/MdePkg/Library/BaseLib/RiscV64/MemoryFence.S
> >> @@ -0,0 +1,33 @@
> >>
> >
+##-------------------------------------------------------------------------
> > -----
> >>
> >>
> >> +#
> >>
> >>
> >> +# MemoryFence() for RiscV64
> >>
> >>
> >> +
> >>
> >>
> >> +# Copyright (c) 2021, Hewlett Packard Enterprise Development. All
rights
> >> reserved.
> >>
> >>
> >> +#
> >>
> >>
> >> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> >>
> >>
> >> +#
> >>
> >>
> >>
> >
+##-------------------------------------------------------------------------
> > -----
> >>
> >>
> >> +
> >>
> >>
> >> +.text
> >>
> >>
> >> +.p2align 2
> >>
> >>
> >> +
> >>
> >>
> >> +ASM_GLOBAL ASM_PFX(MemoryFence)
> >>
> >>
> >> +
> >>
> >>
> >> +
> >>
> >>
> >> +#/**
> >>
> >>
> >> +#  Used to serialize load and store operations.
> >>
> >>
> >> +#
> >>
> >>
> >> +#  All loads and stores that proceed calls to this function are
> > guaranteed to
> >> be
> >>
> >>
> >> +#  globally visible when this function returns.
> >>
> >>
> >> +#
> >>
> >>
> >> +#**/
> >>
> >>
> >> +#VOID
> >>
> >>
> >> +#EFIAPI
> >>
> >>
> >> +#MemoryFence (
> >>
> >>
> >> +#  VOID
> >>
> >>
> >> +#  );
> >>
> >>
> >> +#
> >>
> >>
> >> +ASM_PFX(MemoryFence):
> >>
> >>
> >> +    // Fence on all memory and I/O
> >>
> >>
> >> +    fence
> >>
> >>
> >> +    ret
> >>
> >>
> >> --
> >> 2.30.1
> >>
> >>
> >>
> >>
> >>
> >
> >
> >
> >
> >
> >
> >
> >
>
>
>
>







Join devel@edk2.groups.io to automatically receive all group messages.