Re: [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA consumer


Samer El-Haj-Mahmoud
 

+Ard's new e-mail address

-----Original Message-----
From: Pete Batard <pete@akeo.ie>
Sent: Thursday, April 8, 2021 5:48 AM
To: Jeremy Linton <Jeremy.Linton@arm.com>; devel@edk2.groups.io
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; leif@nuviainc.com; Samer
El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Andrei Warkentin
(awarkentin@vmware.com) <awarkentin@vmware.com>
Subject: Re: [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA
consumer

On 2021.04.08 06:58, Jeremy Linton wrote:
Bridge devices should be marked as producers so that their children
can consume the resources. In linux if this isn't true then the
translation gets ignored and the DMA values are incorrect. This fixes
DMA on all the devices that need a translation.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +-
Platform/RaspberryPi/AcpiTables/Emmc.asl | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/RaspberryPi/AcpiTables/Dsdt.asl
b/Platform/RaspberryPi/AcpiTables/Dsdt.asl
index d116f965e1..32cd5fc9f9 100644
--- a/Platform/RaspberryPi/AcpiTables/Dsdt.asl
+++ b/Platform/RaspberryPi/AcpiTables/Dsdt.asl
@@ -205,7 +205,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 5, "RPIFDN",
"RPI", 2)
// Only the first GB is available.

// Bus 0xC0000000 -> CPU 0x00000000.

//

- QWordMemory (ResourceConsumer,

+ QWordMemory (ResourceProducer,

,

MinFixed,

MaxFixed,

diff --git a/Platform/RaspberryPi/AcpiTables/Emmc.asl
b/Platform/RaspberryPi/AcpiTables/Emmc.asl
index 179dd3ecdb..0fbc2a79ea 100644
--- a/Platform/RaspberryPi/AcpiTables/Emmc.asl
+++ b/Platform/RaspberryPi/AcpiTables/Emmc.asl
@@ -32,7 +32,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN",
"RPI4EMMC", 2)
}



Name (_DMA, ResourceTemplate() {

- QWordMemory (ResourceConsumer,

+ QWordMemory (ResourceProducer,

,

MinFixed,

MaxFixed,
Reviewed-by: Pete Batard <pete@akeo.ie>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Join devel@edk2.groups.io to automatically receive all group messages.