Re: [edk2-platforms] [PATCH v3 2/3] Platform/ARM/SgiPkg: Add HMAT ACPI table for RdN1EdgeX2


Vijayenthiran Subramaniam
 

Hi Sami,

 

Agree with the suggestion. Please make the changes.

 

Regards,

Vijay

 

From: "Sami Mujawar via Groups.Io" <sami.mujawar@...>
Reply to: Sami Mujawar <Sami.Mujawar@...>
Date: Thursday, 8 April 2021 at 12:07 AM
To: Vijayenthiran Subramaniam <Vijayenthiran.Subramaniam@...>, "devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v3 2/3] Platform/ARM/SgiPkg: Add HMAT ACPI table for RdN1EdgeX2

 

Hi Vijay,

+#define HMAT_STRUCTURE_MEMORY_SIDE_CACHE_INFO_CACHE_ATTRIBUTES_INIT( \
+ TotalCacheLevels, CacheLevel, CacheAssociativity, WritePolicy, CacheLineSize \
+ ) \
+{ \
+ TotalCacheLevels, CacheLevel, CacheAssociativity, WritePolicy, CacheLineSize \
+}

This macros is again repeated in patch 3/3. I think this could be moved to Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h.
If you agree I can make this change locally before pushing this series.

Regards,

Sami Mujawar

Join devel@edk2.groups.io to automatically receive all group messages.