Re: [edk2-platforms][PATCH v2 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe


Kun Qin
 

Hi Ard,

Thanks for providing the tag. For my own learning purpose, could you please let me know how I can get a "reviewed-by" tag for this change? Should I add more reviewers than package maintainers listed on "Maintainers.txt"?

Thanks for the help.

Regards,
Kun

On 03/18/2021 11:14, Ard Biesheuvel wrote:
On Thu, 18 Mar 2021 at 19:07, Kun Qin <kuqin12@gmail.com> wrote:

Hi Ard/Leif,

Could you please review the change and let me know if you have any
feedback when there is chance? I can drop the patch if this package is
not supported/maintained any more. Please let me know how you would like
to proceed.

Thanks in advance.

Regards,
Kun

On 03/16/2021 11:10, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250

This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to
resolve new dependency by VariableSmmRuntimeDxe. The library interface
is consumed by variable module to better support variable runtime cache
feature.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>

Signed-off-by: Kun Qin <kuqin12@gmail.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>

---

Notes:
v2:
- No review, no change.

Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
index 0a11b796cca5..acaa4cd90fc5 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
@@ -49,6 +49,8 @@ [LibraryClasses]
TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
!endif

+ MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
+
[LibraryClasses.common.SEC]
PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf

Join devel@edk2.groups.io to automatically receive all group messages.