toggle quoted messageShow quoted text
Thanks for providing the tag. For my own learning purpose, could you please let me know how I can get a "reviewed-by" tag for this change? Should I add more reviewers than package maintainers listed on "Maintainers.txt"?
Thanks for the help.
On 03/18/2021 11:14, Ard Biesheuvel wrote:
On Thu, 18 Mar 2021 at 19:07, Kun Qin <firstname.lastname@example.org> wrote:
Acked-by: Ard Biesheuvel <email@example.com>
Could you please review the change and let me know if you have any
feedback when there is chance? I can drop the patch if this package is
not supported/maintained any more. Please let me know how you would like
Thanks in advance.
On 03/16/2021 11:10, Kun Qin via groups.io wrote:
This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to
resolve new dependency by VariableSmmRuntimeDxe. The library interface
is consumed by variable module to better support variable runtime cache
Cc: Ard Biesheuvel <firstname.lastname@example.org>
Cc: Leif Lindholm <email@example.com>
Signed-off-by: Kun Qin <firstname.lastname@example.org>
- No review, no change.
Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
index 0a11b796cca5..acaa4cd90fc5 100644
@@ -49,6 +49,8 @@ [LibraryClasses]