Re: [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard


Dong, Eric
 

Reviewed-by: Eric Dong <eric.dong@intel.com>

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Tuesday, March 16, 2021 11:34 AM
To: devel@edk2.groups.io
Cc: Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>
Subject: [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard

The change doesn't impact any functionality.

Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
---
UefiCpuPkg/CpuDxe/CpuGdt.c | 27 +++++++++++++--------------
1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/UefiCpuPkg/CpuDxe/CpuGdt.c b/UefiCpuPkg/CpuDxe/CpuGdt.c
index a1ab543f2d..322ce87142 100644
--- a/UefiCpuPkg/CpuDxe/CpuGdt.c
+++ b/UefiCpuPkg/CpuDxe/CpuGdt.c
@@ -2,7 +2,7 @@
C based implementation of IA32 interrupt handling only

requiring a minimal assembly interrupt entry point.



- Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR>

+ Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>

SPDX-License-Identifier: BSD-2-Clause-Patent



**/

@@ -13,7 +13,7 @@
//

// Global descriptor table (GDT) Template

//

-STATIC GDT_ENTRIES GdtTemplate = {

+STATIC GDT_ENTRIES gGdtTemplate = {

//

// NULL_SEL

//

@@ -124,32 +124,31 @@ InitGlobalDescriptorTable (
VOID

)

{

- GDT_ENTRIES *gdt;

- IA32_DESCRIPTOR gdtPtr;

+ GDT_ENTRIES *Gdt;

+ IA32_DESCRIPTOR Gdtr;



//

// Allocate Runtime Data for the GDT

//

- gdt = AllocateRuntimePool (sizeof (GdtTemplate) + 8);

- ASSERT (gdt != NULL);

- gdt = ALIGN_POINTER (gdt, 8);

+ Gdt = AllocateRuntimePool (sizeof (gGdtTemplate) + 8);

+ ASSERT (Gdt != NULL);

+ Gdt = ALIGN_POINTER (Gdt, 8);



//

// Initialize all GDT entries

//

- CopyMem (gdt, &GdtTemplate, sizeof (GdtTemplate));

+ CopyMem (Gdt, &gGdtTemplate, sizeof (gGdtTemplate));



//

// Write GDT register

//

- gdtPtr.Base = (UINT32)(UINTN)(VOID*) gdt;

- gdtPtr.Limit = (UINT16) (sizeof (GdtTemplate) - 1);

- AsmWriteGdtr (&gdtPtr);

+ Gdtr.Base = (UINT32) (UINTN) Gdt;

+ Gdtr.Limit = (UINT16) (sizeof (gGdtTemplate) - 1);

+ AsmWriteGdtr (&Gdtr);



//

// Update selector (segment) registers base on new GDT

//

- SetCodeSelector ((UINT16)CPU_CODE_SEL);

- SetDataSelectors ((UINT16)CPU_DATA_SEL);

+ SetCodeSelector ((UINT16) CPU_CODE_SEL);

+ SetDataSelectors ((UINT16) CPU_DATA_SEL);

}

-

--
2.27.0.windows.1

Join devel@edk2.groups.io to automatically receive all group messages.