Re: [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm


Laszlo Ersek
 

Hi

On 01/22/21 05:40, Kun Qin wrote:
Hi Ray,

I was suggested not to rename the file for review easiness and git history concern during v2 patch. Thread here: Re: [PATCH v2 15/16] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm (groups.io)<https://edk2.groups.io/g/devel/message/69857>
I think you misunderstood my v2 comments.

I requested that we please separate the renaming of *variables* to
dediacted patches. And, this referred primarily to the gSmst --> gMmst
replacement.

I didn't even *intend* to comment on the renaming of *files*, as far as
I can tell.

Renaming the *files*, as Ray suggests, seems reasonable. And if you can
split those actions to yet another patch, that's best.

Thanks
Laszlo



Please let me know if you still recommend renaming the files. If so, would you suggest ```CpuIo2Smm.c/h --> CpuIo2Mm.c/h # remove the "S"``` to be a separate patch between gSmst change and adding Standalone MM instance?

Thanks in advance.

Regards,
Kun

From: Ni, Ray<mailto:ray.ni@...>
Sent: Thursday, January 21, 2021 20:17
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; kun.q@...<mailto:kun.q@...>
Cc: Dong, Eric<mailto:eric.dong@...>; Laszlo Ersek<mailto:lersek@...>; Kumar, Rahul1<mailto:rahul1.kumar@...>
Subject: RE: [edk2-devel] [PATCH v3 17/18] UefiCpuPkg: CpuIo2Smm: Support of CpuIo driver under StandaloneMm


UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.c | 9 ++----
UefiCpuPkg/CpuIo2Smm/CpuIo2StandaloneMm.c | 32 ++++++++++++++++++++
UefiCpuPkg/CpuIo2Smm/CpuIo2TraditionalMm.c | 32 ++++++++++++++++++++
UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.h | 12 ++++++++
UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf | 3 +-
UefiCpuPkg/CpuIo2Smm/{CpuIo2Smm.inf => CpuIo2StandaloneMm.inf} | 18 +++++------
UefiCpuPkg/UefiCpuPkg.dsc | 5 +++

How about do the file name change as below?
CpuIo2Smm.c/h --> CpuIo2Mm.c/h # remove the "S"
CpuIo2TraditionalMm.c -> CpuIo2Smm.c # Traditional MM equals to SMM. It also matches to CpuIo2Smm.inf.
CpuIo2StandaloneMm.c/inf # looks good to me.


Join devel@edk2.groups.io to automatically receive all group messages.