Re: 回复: [edk2-devel] [Patch 0/2] Convert Split tool to python
|
Bob Feng
Liming,
I have sent the patch V3 that is to move the unit test to tests/Split folder.
Do you have any other concerns about this patch?
Thanks, Bob
From: Feng, Bob C
Sent: Friday, January 15, 2021 9:50 AM To: devel@edk2.groups.io; gaoliming@... Cc: Feng, Bob C <bob.c.feng@...> Subject: RE: [edk2-devel] 回复: [edk2-devel] [Patch 0/2] Convert Split tool to python
Hi Liming,
1. The test framework can be used for both incremental test and functionality test. We can do more discussion when I send out this framework for review. 2. Yes, I agree to add a sub folder under the test folder. I’ll update the patch.
Is there any other comments before I send the patch V2?
Thanks, Bob
From:
devel@edk2.groups.io <devel@edk2.groups.io>
On Behalf Of gaoliming
Bob: Thanks for your planning sharing. For BaseTools test, I still have some questions.
1. For test framework, is it the incremental test framework or the functionality test framework or both? 2. For BaseTools\Source\Python\tests\test_split.py, it creates new directory ‘tests’ for test case scripts, and use test_split.py for split tool. So, new tool test script will follow the same style. Besides, split tool is simple. It may not have its special test case. But, Fce/FMMT are too complex. They need the different bios images as their test cases. Then, where are those test cases placed into? I would prefer to place the test script and its test cases into the same directory. So, I would propose to create the subdirectory in ‘tests’ for each tool test, such as Split for this case. Then, every tool can place its test script and test case into its own directory.
Thanks Liming 发件人:
tosubbounce+27952+0+0+0@groups.io <tosubbounce+27952+0+0+0@groups.io>
代表 Bob Feng
Good questions. I answer them inline.
I am still investigating the feasibility of converting the C tools to Python tools. Some C tools are simple but some are complex. I hope all the C tools can be converted to Python tools so that all the tools can be moved to the BaseTools
separate repo. I think we can file some BZs to track the progress of the C tools conversion. And I hope there could be more volunteers to be involved in this work.
Except for this patch, my current work for Basetools are:
The unittest is the python build-in library for the unit test.
https://docs.python.org/3/library/unittest.html
|
|
|