Re: [PATCH] ArmPlatformPkg/NorFlashDxe: use correct PCD accessors


Sami Mujawar
 

Hi Ard, Philippe,

I will check if the Kvmtool.dsc build can be supported using the edk2 Core CI.

Regards,

Sami Mujawar

-----Original Message-----
From: Ard Biesheuvel <ard.biesheuvel@...>
Sent: 12 January 2021 12:10 PM
To: Philippe Mathieu-Daudé <philmd@...>; devel@edk2.groups.io
Cc: leif@...; Vijayenthiran Subramaniam <Vijayenthiran.Subramaniam@...>; Masahisa Kojima <masahisa.kojima@...>; Sami Mujawar <Sami.Mujawar@...>; Michael D Kinney <michael.d.kinney@...>
Subject: Re: [edk2-devel] [PATCH] ArmPlatformPkg/NorFlashDxe: use correct PCD accessors

On 1/12/21 12:42 PM, Philippe Mathieu-Daudé wrote:
Hi Ard,

On 1/11/21 11:57 AM, Ard Biesheuvel wrote:
Commit 8015f3f6d4005d83 ("ArmPlatformPkg: Enable support for flash in
64-bit address space") updated the NorFlash DXE and StMM drivers to
take alternate PCDs into account when discovering the base of the
NOR flash regions.

This introduced a disparity between the declarations of the PCD references
in the .INF files, which permits the use of dynamic PCDs, and the code
itself, which now uses FixedPcdGet() accessors. On platforms that actually
use dynamic PCDs, this results in a build error.
So there is no (mainstream) CI coverage for these platforms?
Could we add at least one?
We could. It was KvmTool.dsc, which lives in the main repo.

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Join devel@edk2.groups.io to automatically receive all group messages.