- 回复: 回复: [edk2-devel] please let's disable the ECC plugin in CI, in its current form
回复: 回复: [edk2-devel] please let's disable the ECC plugin in CI, in its current form
toggle quoted messageShow quoted text
发件人: Sean Brogan <firstname.lastname@example.org>
发送时间: 2020年12月9日 2:37
收件人: email@example.com; firstname.lastname@example.org;
email@example.com; 'Michael Kinney' <firstname.lastname@example.org>; 'Sean
Brogan' <email@example.com>; 'Ard Biesheuvel (ARM address)'
<firstname.lastname@example.org>; 'Leif Lindholm (Nuvia address)'
<email@example.com>; 'Andrew Fish' <firstname.lastname@example.org>
主题: Re: 回复: [edk2-devel] please let's disable the ECC plugin in CI, in its
I agree it would be great to get to a place where a package maintainer
could turn this on but because of this bug
https://bugzilla.tianocore.org/show_bug.cgi?id=2986 I think this needs
to be completely disabled until the above is resolved.
On 12/8/2020 7:38 AM, gaoliming wrote:
Laszlo:CI. But, I request to expose the option to enable it per package. If the
ECC tool is not perfect. It is still helpful. I am OK to disable ECC plugin in
package maintainer thinks ECC is valuable, he can enable ECC plugin in one
package. As MdePkg maintainer, I can help to resolve ECC issue in MdePkg
patch. So, I would keep ECC plugin in MdePkg.
<email@example.com> 代表 Laszlo
发送时间: 2020年12月8日 10:05
收件人: Michael Kinney <firstname.lastname@example.org>; Sean Brogan
<email@example.com>; Ard Biesheuvel (ARM address)
<firstname.lastname@example.org>; Leif Lindholm (Nuvia address)
<email@example.com>; Andrew Fish <firstname.lastname@example.org>
抄送: edk2-devel-groups-io <email@example.com>
主题: [edk2-devel] please let's disable the ECC plugin in CI, in its current
in my opinion, the ECC plugin in CI has not been productive or helpful.
The errors it reports are not convincing, and exceptions are difficult
to add, or even express. I request that we disable ECC globally for
edk2, or at least make it controllable through a github PR flag (not
through CI metafile changes in edk2).
(Metafile changes could be an acceptable way of controlling ECC if (a)
they didn't have to go through review, (b) if technically such changes
would take effect in CI even if they were included in the patch series
subject to the CI run. Then a maintainer could evaluate and
*immediately* suppress such ECC issues by adding the exceptions as a
prepended patch, and force-pushing the updated branch to the same open
PR. But this would remain much inferior to simply disabling ECC, or
controlling it through a PR label.)
Join firstname.lastname@example.org to automatically receive all group messages.