Sorry for the thrash on this; in testing the GCC build with .S files, I found that there is still a build failure due to the inclusion of a "common" data section in the OpenSSL code, which is explicitly removed by Base Tools changes in commit 214a3b79417f. So I think without removing this restriction or changing OpenSSL in a future patch, we will not be able to build the accelerated functions for GCC.
toggle quoted messageShow quoted text
From: email@example.com <firstname.lastname@example.org> On Behalf Of Laszlo Ersek
Sent: Wednesday, November 11, 2020 11:09
To: Yao, Jiewen <email@example.com>; Zurcher, Christopher J
Cc: firstname.lastname@example.org; gaoliming <email@example.com>; Wang, Jian J
<firstname.lastname@example.org>; Lu, XiaoyuX <email@example.com>; Kinney, Michael
D <firstname.lastname@example.org>; Ard Biesheuvel <email@example.com>
Subject: Re: [edk2-devel] [PATCH v5 0/2] CryptoPkg/OpensslLib: Add native
instruction support for X64
On 11/11/20 03:19, Yao, Jiewen wrote:
I full agree with long term plan. E.g. we need remove ApiHook.c as well.get the capability.
I more concern about the short term plan, if you want to check in this and
check in .S.
I think we need this capability for GCC tool chain as well, so I am OK to
This is auto generated. I do not think it is a step back.Agreed on all counts.
We can remove them together with ApiHook later, in the long term.