Re: [PATCH] RedfishPkg: Use DSC include file


Nickle Wang
 

Reviewed-by: Nickle Wang <nickle.wang@...>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner
Chang
Sent: Thursday, November 12, 2020 8:44 AM
To: devel@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@...>; O'Hanley, Peter (EXL)
<peter.ohanley@...>
Subject: [edk2-devel] [PATCH] RedfishPkg: Use DSC include file

- Include Redfish.dsc.inc in RedfishPkg.dsc. which
consolidates the necessary components in Redfish.dsc.inc.
- Remove unnecessary library instances from RedfishPkg.dsc.
- Add build option in RedfishPkg.yaml.

Signed-off-by: Abner Chang <abner.chang@...>
Cc: Nickle Wang <nickle.wang@...>
Cc: Peter O'Hanley <peter.ohanley@...>
---
RedfishPkg/RedfishPkg.ci.yaml | 3 ++-
RedfishPkg/RedfishPkg.dsc | 10 +---------
2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
index bb3b8b6746..20c297ad22 100644
--- a/RedfishPkg/RedfishPkg.ci.yaml
+++ b/RedfishPkg/RedfishPkg.ci.yaml
@@ -63,6 +63,7 @@
},

"Defines": {
- "BLD_*_CONTINUOUS_INTEGRATION": "TRUE"
+ "BLD_*_CONTINUOUS_INTEGRATION": "TRUE",
+ "BLD_*_REDFISH_ENABLE": "TRUE"
}
}
diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
index c6e79f5645..94e7127bc6 100644
--- a/RedfishPkg/RedfishPkg.dsc
+++ b/RedfishPkg/RedfishPkg.dsc
@@ -23,21 +23,14 @@

UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBo
otServicesTableLib.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf

UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib
/UefiRuntimeServicesTableLib.inf
- UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf

MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemo
ryAllocationLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
-
SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchroniz
ationLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf

DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Bas
eDebugPrintErrorLevelLib.inf
-
PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort
80.inf
PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
-
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base
PeCoffGetEntryPointLib.inf
-
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTabl
eLib.inf
- DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
-
ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/Dx
eReportStatusCodeLib.inf

RedfishPlatformHostInterfaceLib|RedfishPkg/Library/PlatformHostInterface
LibNull/PlatformHostInterfaceLibNull.inf

[LibraryClasses.ARM, LibraryClasses.AARCH64]
@@ -51,5 +44,4 @@
[Components]

RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceLibN
ull.inf

- RedfishPkg/RestJsonStructureDxe/RestJsonStructureDxe.inf
- RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.inf
+ !include RedfishPkg/Redfish.dsc.inc
--
2.17.1




Join devel@edk2.groups.io to automatically receive all group messages.