Re: CI test on copyright


Abner Chang
 

Hmm, it doesn’t work with below header. Still fail.

 

## @file

# Implementation of EFI REST JSON Structure Protocol.

#

#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

#  SPDX-License-Identifier: BSD-2-Clause-Patent

##

 

I had confirmed it again, CI test passed with below one, move “(C)” to behind Copyright.

## @file

# Implementation of EFI REST JSON Structure Protocol.

#

#  Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

#  SPDX-License-Identifier: BSD-2-Clause-Patent

##

 

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Friday, October 16, 2020 12:35 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@...>
Subject: Re: [edk2-devel] CI test on copyright

 

Try removing the extra line between “SPDX” and “##”.

 

- Bret

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Thursday, October 15, 2020 9:32 AM
To: Bret Barkelew; devel@edk2.groups.io
Cc: Sean Brogan
Subject: [EXTERNAL] RE: CI test on copyright

 

 

## @file

# Implementation of EFI REST JSON Structure Protocol.

#

#  (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

#  SPDX-License-Identifier: BSD-2-Clause-Patent

#

##

 

Or you can check the PR,

https://github.com/tianocore/edk2/pull/1019

 

Abner

 

From: Bret Barkelew [mailto:Bret.Barkelew@...]
Sent: Friday, October 16, 2020 12:24 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@...>; devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@...>
Subject: RE: CI test on copyright

 

Can you share the entire copyright header? In my experience, It’s actually complaining about one of the ‘#’ or ‘/*’ tags.

 

- Bret

 

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Thursday, October 15, 2020 9:21 AM
To: devel@edk2.groups.io
Cc: Bret Barkelew; Sean Brogan
Subject: [EXTERNAL] CI test on copyright

 

Hi Sean and Bret,

I got the CI test error which says the first line in file header section must have the copyright information, however the copyright is there and looks to me fine as below,

(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>

 

 

 

The interesting part is CI seems happy with below format of copyright, and this issue only happens on INF file but not on the *.c and *.h.

Copyright (C) 2020 Hewlett Packard Enterprise Development LP<BR>

 

Any idea on this?

Abner

 

 

Join devel@edk2.groups.io to automatically receive all group messages.