回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".


gaoliming
 

The pull request needs rebase. I will submit new pull request today.

Thanks
Liming

-----邮件原件-----
发件人: Liu, Zhiguang <zhiguang.liu@intel.com>
发送时间: 2020年10月10日 8:49
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
<michael.d.kinney@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
'Sean Brogan' <spbrogan@outlook.com>
主题: RE: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5
definitions".

Hi Liming

In pull request https://github.com/tianocore/edk2/pull/996
Merge failed because
tanocore.PatchCheck Failing after 34s — Build #20201009.4 failed

Detail:
The commit message format is not valid:
* Missing Signed-off-by! (Note: this must be added by the code contributor!)
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-For
mat

However, I abstract the patch from Outlook and run PatchCheck to check it in
my local machine, the result is ok.

Detail:
E:\edk2\BaseTools\Scripts>py PatchCheck.py
0001-MdePkg-SMBIOS-3.4.0-Update-adding-DDR5-definitions-.patch
Checking patch file:
0001-MdePkg-SMBIOS-3.4.0-Update-adding-DDR5-definitions-.patch
[PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".
The commit message format passed all checks.
The code passed all checks.

Do you know why?

Thanks
Zhiguang
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Friday, October 9, 2020 5:21 PM
To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
<michael.d.kinney@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
'Sean
Brogan' <spbrogan@outlook.com>
Subject: 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
"adding
DDR5 definitions".

https://github.com/tianocore/edk2/pull/996 is created.

-----邮件原件-----
发件人: bounce+27952+66054+4905953+8761045@groups.io
<bounce+27952+66054+4905953+8761045@groups.io> 代表 Zhiguang
Liu
发送时间: 2020年10月9日 15:24
收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
<michael.d.kinney@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
Sean Brogan <spbrogan@outlook.com>
主题: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding
DDR5
definitions".

Hi Liming,
This patch also gets R-B from Sean Brogan.
Please help merge this patch.

Thanks
Zhiguang

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
gaoliming
Sent: Wednesday, September 30, 2020 8:45 AM
To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
<michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
"adding
DDR5 definitions".

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

-----邮件原件-----
发件人: bounce+27952+65712+4905953+8761045@groups.io
<bounce+27952+65712+4905953+8761045@groups.io> 代表
Zhiguang
Liu
发送时间: 2020年9月29日 16:12
收件人: devel@edk2.groups.io; Liu, Zhiguang
<zhiguang.liu@intel.com>
抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
<michael.d.kinney@intel.com>; Liming Gao
<gaoliming@byosoft.com.cn>
主题: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
"adding
DDR5
definitions".


Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
Zhiguang
Liu
Sent: Tuesday, September 29, 2020 4:09 PM
To: devel@edk2.groups.io
Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
<michael.d.kinney@intel.com>; Liming Gao
<gaoliming@byosoft.com.cn>
Subject: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
"adding
DDR5 definitions".

From: "Wang, Sanyo" <sanyo.wang@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2352

SMBIOS 3.4 spec adds new memory device types (DDR5, LPDDR5)

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Sanyo Wang <sanyo.wang@intel.com>
---
MdePkg/Include/IndustryStandard/SmBios.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
b/MdePkg/Include/IndustryStandard/SmBios.h
index ea23685851..f2db11f947 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -1718,7 +1718,9 @@ typedef enum {
MemoryTypeLpddr4 = 0x1E,

MemoryTypeLogicalNonVolatileDevice = 0x1F,

MemoryTypeHBM = 0x20,

- MemoryTypeHBM2 = 0x21

+ MemoryTypeHBM2 = 0x21,

+ MemoryTypeDdr5 = 0x22,

+ MemoryTypeLpddr5 = 0x23

} MEMORY_DEVICE_TYPE;



///

--
2.25.1.windows.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65711):
https://edk2.groups.io/g/devel/message/65711
Mute This Topic: https://groups.io/mt/77191807/1779286
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub
[zhiguang.liu@intel.com]
-=-=-=-=-=-=











Join devel@edk2.groups.io to automatically receive all group messages.