Re: [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL pointer check


Wu, Hao A
 

Pushed via commit 698d3d7726232694018d437279dd4166e462deb7.

Best Regards,
Hao Wu

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wu, Hao A
Sent: Tuesday, September 15, 2020 9:48 AM
To: Jeff Brasen <jbrasen@...>; devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@...>
Subject: Re: [edk2-devel] [PATCH]
MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL pointer check

Reviewed-by: Hao A Wu <hao.a.wu@...>

Best Regards,
Hao Wu

-----Original Message-----
From: Jeff Brasen <jbrasen@...>
Sent: Saturday, September 12, 2020 1:17 AM
To: devel@edk2.groups.io
Cc: Wu, Hao A <hao.a.wu@...>; Ni, Ray <ray.ni@...>; Jeff
Brasen <jbrasen@...>
Subject: [PATCH] MdeModulePkg/NonDiscoverablePciDeviceDxe: Add NULL
pointer check

Add check for NULL HostAddress in AllocateBuffer as required by UEFI
specification.

Signed-off-by: Jeff Brasen <jbrasen@...>
---
.../NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 4
++++
1 file changed, 4 insertions(+)

diff --git
a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
PciDeviceIo.c
b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
PciDeviceIo.c
index a40c1a9593..363c4a765b 100644
---
a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
PciDeviceIo.c
+++
b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
Pc
+++ iDeviceIo.c
@@ -856,6 +856,10 @@ CoherentPciIoAllocateBuffer (
return EFI_UNSUPPORTED; } + if (HostAddress == NULL) {+ return
EFI_INVALID_PARAMETER;+ }+ if ((MemoryType != EfiBootServicesData)
&& (MemoryType != EfiRuntimeServicesData)) { return
EFI_INVALID_PARAMETER;--
2.25.1

Join devel@edk2.groups.io to automatically receive all group messages.