toggle quoted messageShow quoted text
The patchset includes 3 patches, and all of them had been reviewed by package owners.
The patch submitter has a pull request https://github.com/tianocore/edk2/pull/885
, I rebased the patch to latest master, and merged it by adding reviewed-by found from emails.
I also make sure it passed all the checks before I put "push" button there. then retrigger a new build with "push" button.
I am not sure what is missing. If there is any other requirements, should they be captured during code review or tool check?
From: firstname.lastname@example.org <email@example.com> On Behalf Of Laszlo
Sent: Wednesday, September 16, 2020 1:57 AM
To: Dong, Guo <guo.dong@...>
Cc: firstname.lastname@example.org; marcello.bauer@...; Kinney, Michael D
<michael.d.kinney@...>; Leif Lindholm (Nuvia address)
<leif@...>; Doran, Mark <mark.doran@...>; Andrew Fish
<afish@...>; Guptha, Soumya K <@SoumyaGuptha>
Subject: [edk2-devel] more development process failure [was: UefiPayloadPkg:
On 08/18/20 10:24, Marcello Sylvester Bauer wrote:
Support arbitrary platforms with different or even no MMCONF space.MMCONF
Fixes crash on platforms not exposing 256 buses.
* AMD Stoney Ridge
PR: https://github.com/tianocore/edk2/pull/885Okay, so we got more of the same development process violations here, as
- support variable size MMCONF in all PciExpressLibs
- use (UINTX)-1 as return values for invalid Pci addresses
I've just reported at <https://edk2.groups.io/g/devel/message/65313>.
See this new pull request:
"No description provided."
You should be embarrassed.