Re: [PATCH v7 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Vladimir Olovyannikov

Hi Laszlo,
No worries, please let me know if you have any comments/concerns down the

Thank you,

-----Original Message-----
From: Laszlo Ersek <lersek@...>
Sent: Wednesday, August 26, 2020 6:56 AM
To:; vladimir.olovyannikov@...
Cc: Maciej Rabeda <maciej.rabeda@...>; Zhichao Gao
<zhichao.gao@...>; Jiaxin Wu <jiaxin.wu@...>; Siyuan Fu
<siyuan.fu@...>; Ray Ni <>; Liming Gao
<liming.gao@...>; Nd <nd@...>; Samer El-Haj-Mahmoud
Subject: Re: [edk2-devel] [PATCH v7 0/1] ShellPkg/DynamicCommand: add

Hi Vladimir,

On 08/25/20 19:20, Vladimir Olovyannikov via wrote:
Signed-off-by: Vladimir Olovyannikov
Reviewed-by: Maciej Rabeda <maciej.rabeda@...>
Cc: Zhichao Gao <zhichao.gao@...>
Cc: Maciej Rabeda <maciej.rabeda@...>
Cc: Jiaxin Wu <jiaxin.wu@...>
Cc: Siyuan Fu <siyuan.fu@...>
Cc: Ray Ni <>
Cc: Liming Gao <liming.gao@...>
Cc: Nd <nd@...>
Cc: Laszlo Ersek <lersek@...>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@...>

This patchset introduces an http client utilizing EDK2 HTTP protocol,
to allow fast image downloading from http/https servers.
HTTP download speed is usually faster than tftp.
The client is based on the same approach as tftp dynamic command, and
uses the same UEFI Shell command line parameters. This makes it easy
integrating http into existing UEFI Shell scripts.
Note that to enable HTTP download, feature Pcd
gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to


PATCH v7 changes:
Address Laszlo' and Maciej's comments:
- Remove openssl submodule change accidentally added to the v6
- Fix code style issues in the code overlooked in the previous
I'm currently working on some VCPU hotplug fixes for the upcoming release.
Before I return to your HttpDynamicCommand patch, I'll also have to
my earlier comments for it. (In fact I can't tell off-hand if I had
requests for your patch, or not -- hence the need for re-reading my
comments.) It could take some time -- thanks for your patience.


Join to automatically receive all group messages.