Re: 答复: [edk2-devel] Patch List for 202008 stable tag



[] 代表 Laszlo
发送时间: 2020年8月21日 19:07
收件人: Gao, Liming <liming.gao@...>; Leif Lindholm
<leif@...>; afish@...; Kinney, Michael D
<michael.d.kinney@...>; Guptha, Soumya K
<soumya.k.guptha@...>; Chang, Abner (HPS SW/FW Technologist)
<abner.chang@...>; Vladimir Olovyannikov
<vladimir.olovyannikov@...>; Tom Lendacky
主题: Re: [edk2-devel] Patch List for 202008 stable tag

On 08/20/20 13:30, Gao, Liming wrote:
Hi Stewards and all:
I collect current patch lists in devel mail list. Those patch
request to add them for 202008 stable tag. Because we have enter into Soft
Feature Freeze, I want to collect your feedback for them. If any patches
missing, please reply this mail to add them.

Feature List: [PATCH]
EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp [Liming] This
patch pass code review after Soft Feature Freeze (SFF) starts. According
to SFF
definition, it should not be merged for this stable tag. But, the patch
says this patch is important to RISC-V community. To catch it for this
stable tag,
Laszlo proposed the solution to defer SFF start day from 2020-08-14 to
2020-08-21, then hard feature freeze and release date will also defer one
week. Any patches those pass review before new SFF start day can be
@ Stewards, please give your comments to defer this stable tag release by
one week.

Thank you, very nice summary.

As stated earlier, I'm OK with 1 week (or even two weeks, if needed)
extension. I invite Andrew, Leif and Mike to comment.
[Liming] I don't see any other urgent request. I think it is enough to defer
1 week for this stable tag.
So far, there is objection for this defer. I will send the announcement
mail. [PATCH v5 1/1]
ShellPkg/DynamicCommand: add HttpDynamicCommand [Liming] This
patch has collected the review comment. New version will be sent. I have
information how important it is. @Vladimir, does this patch must catch
stable tag? If yes, can you give the reason?

This is a feature addition. While it's a super useful feature, it needs to
(mainly from the coding style perspective, as I gather).
Posting of new versions and review are on-going.

Most likely material for the next stable tag. In case we extend the
and Maciej and the ShellPkg maintainers approve one of the upcoming
versions until the new SFF, then yes, we can merge that too.
[Liming] So, this is not urgent. Let's defer it to next stable tag.


Bug List: [PATCH 1/1]
UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable
This patch has collected the review comment. New version will be sent.

This is a bugfix. Certainly a build fix on CLANGPDB. I tried to do some
(lightweight) analysis to see whether the bug is a functional one as well
whether the bad code path that CLANG warns about can actually occur in
practice), but in the end I didn't want to spend much time on it, as the
breakage needs to be fixed anyway.

So, this patch (more precisely, v2 of this patch) would even qualify
during the
hard feature freeze (as it's clearly a bugfix). [PATCH 1/1]
MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h
[Liming] This patch passed review early. But, it is not merged. I will
merge it.

Right, it was approved on 2019-Nov-18. If it still applies cleanly, it
should be
merged, before we enter the Hard Feature Freeze.

Well... now that I'm writing this, we have already entered the HFF (as
originally) and the patch doesn't seem to be upstream yet. So unless we
extend, I don't think this patch qualifies.

(On the other hand -- it seems like we really should extend.)


Join to automatically receive all group messages.