Re: acpiview error handling patches


Sami Mujawar
 

Hi Zhichao,

Some patches in this series need reworking.

Example - For '[PATCH v3 1/8] ShellPkg/AcpiView: Extract configuration struct' & '[PATCH v3 2/8] ShellPkg/AcpiView: Declutter error counters'
I feel accessor methods offer a better design and should be retained.

Other patches in the series need a bit of rework to follow coding conventions etc.

This patch series has too many changes to the parsers. I request to put this patch series on hold as we have other patches that need to go in on priority. e.g. loop detection in PPTT table.

Since Tomas is no longer with Arm, someone from Arm will pick up repost the reworked series.

Regards,

Sami Mujawar

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gao, Zhichao via groups.io
Sent: 31 July 2020 01:43 AM
To: devel@edk2.groups.io; tomas@...
Subject: Re: [edk2-devel] acpiview error handling patches

I am busy at other works recent weeks. I plan to review the patch in next two weeks. Hope it is acceptable for you.

Thanks,
Zhichao

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tomas
Pilar
(tpilar)
Sent: Wednesday, July 29, 2020 7:23 PM
To: Gao; Gao, Zhichao <zhichao.gao@...>; devel@edk2.groups.io
Subject: Re: [edk2-devel] acpiview error handling patches

(change of email)

Hi Zhichao,

I've amended the patches and respun a v3 version. Any chance you could
have a look to see if I've fixed the issues correctly?

Cheers,
Tom




IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Join devel@edk2.groups.io to automatically receive all group messages.