Re: [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor

Laszlo Ersek
 

On 07/31/20 23:14, Laszlo Ersek wrote:

Regarding actual actions: I'm going to be away for a short while now.
Plus, I'm not entirely sure what exactly is being prevented by the
current state of the tree (i.e., how grave the regression is).

(1) If the current issue interferes with work on, and usability of,
other packages (that is, anything *not* OvmfPkg), then I would request
that one of the stewards please revert 656419f922c0 ("Add BhyvePkg, to
support the bhyve hypervisor", 2020-07-31). For such a revert, please
add at once:

Acked-by: Laszlo Ersek <lersek@...>

This is because the IRL stuff I've got queued up does not allow me to
participate in the revert, urgently, either from the reviewer side, or
even from the submitter side. (I wouldn't like to simply push a revert
without formal review, and I don't have time to *post* the revert
urgently). I was about to disappear for a bit, and logged back in only
because I snuck a peek on the mailing list archive, and noticed the
problem report.

After the revert, Rebecca and I can collaborate on the next version of
the patch (I can review that incrementally against the one being
reverted under this option).

(2) If, on the other hand, the current issue is restricted to OvmfPkg
(and even OvmfPkg platforms other than bhyve can be built), then I'd
like to ask that we keep commit 656419f922c0, and that Rebecca please
submit an incremental fix (per the above suggestions, assuming they work).

... Upon re-reading your comment "causing the other packages to fail", I
think we have case (1); if that's right, then please proceed accordingly.
I'm proposing a fix here, rather than a revert:

[edk2-devel] [PATCH]
OvmfPkg: fix DEC spec violation introduced by Bhyve addition

https://edk2.groups.io/g/devel/message/63619
http://mid.mail-archive.com/20200801155024.16439-1-lersek@...

The posting includes links to a fetchable topic branch and to a personal
CI build.

I'd really prefer merging this patch, instead of a "revert & redo".

Thanks
Laszlo

Join devel@edk2.groups.io to automatically receive all group messages.