Re: [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.


Chiu, Chasel
 

Thanks Sean and I will correct the copyright typo.
We will evaluate Core CI enabling.

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean
Sent: Wednesday, June 10, 2020 2:55 PM
To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@...>
Cc: Ma, Maurice <maurice.ma@...>; Desimone, Nathaniel L
<nathaniel.l.desimone@...>; Zeng, Star <star.zeng@...>
Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.

I think your copyright year is off. 2022?

After you fix that

Reviewed-by: Sean Brogan <sean.brogan@...>

Also since you are the package maintainer of this package what do you think
about enabling Core CI? We do this already in Project Mu which is how
this missing entry was identified.
https://github.com/microsoft/mu_silicon_intel_tiano/blob/release/202002/I
ntelFsp2Pkg/IntelFsp2Pkg.ci.yaml


Thanks
Sean


On 6/9/2020 7:33 PM, Chiu, Chasel wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2788

DSC is incomplete according to the established CI policies.
Fsp22SecCoreS.inf needs to be added to the Components section for
completeness.

Cc: Maurice Ma <maurice.ma@...>
Cc: Nate DeSimone <nathaniel.l.desimone@...>
Cc: Star Zeng <star.zeng@...>
Signed-off-by: Chasel Chiu <chasel.chiu@...>
---
IntelFsp2Pkg/IntelFsp2Pkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.dsc
b/IntelFsp2Pkg/IntelFsp2Pkg.dsc index 02fe9cb188..9b5e38c5d9 100644
--- a/IntelFsp2Pkg/IntelFsp2Pkg.dsc
+++ b/IntelFsp2Pkg/IntelFsp2Pkg.dsc
@@ -1,7 +1,7 @@
## @file
# Provides driver and definitions to build fsp.
#
-# Copyright (c) 2014 - 2016, Intel Corporation. All rights
reserved.<BR>
+# Copyright (c) 2014 - 2022, Intel Corporation. All rights
+reserved.<BR>
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
@@ -65,6 +65,7 @@
IntelFsp2Pkg/FspSecCore/FspSecCoreT.inf
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf
IntelFsp2Pkg/FspSecCore/FspSecCoreS.inf
+ IntelFsp2Pkg/FspSecCore/Fsp22SecCoreS.inf
IntelFsp2Pkg/FspNotifyPhase/FspNotifyPhasePeim.inf

[PcdsFixedAtBuild.common]

Join devel@edk2.groups.io to automatically receive all group messages.