Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer: use correct argument count for _EVT ACPI method


Ard Biesheuvel
 

On 5/26/20 10:49 PM, Leif Lindholm wrote:
On Mon, May 25, 2020 at 20:24:55 +0200, Ard Biesheuvel wrote:
The _EVT method on the ACPI0013 Generic Event device takes a single
argument. Even though we are not interested in its value (given that
there is only one interrupt source), we still have to declare the
prototype correctly, or the OS might complain and refuse to call it.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...>
Reviewed-by: Leif Lindholm <leif@...>
Thanks

Pushed as 7121691cfcbc..85a50de1b459

---
Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
index 0ea8ce6d5f44..50f1753c3565 100644
--- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
+++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
@@ -226,7 +226,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR",
MASK = 0xfffffeff
}
- Method (_EVT) {
+ Method (_EVT, 0x1) {
REQC = 0x100
Notify (\_SB.PWRB, 0x80)
}
--
2.17.1

Join {devel@edk2.groups.io to automatically receive all group messages.