Re: [PATCH 1/3] BaseTools: add handling for 'S:' flag to GetMaintainer.py


Bob Feng
 

Reviewed-by: Bob Feng <bob.c.feng@...>

-----Original Message-----
From: Leif Lindholm <leif@...>
Sent: Thursday, April 30, 2020 12:36 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@...>; Gao, Liming <liming.gao@...>
Subject: [PATCH 1/3] BaseTools: add handling for 'S:' flag to GetMaintainer.py

GetMaintainer.py already extracts the value of any S: tags for sections, but it doesn't do anything with that information.

Print a warning message, with the status, for each matching section with a status explicitly set to anything other than 'Supported' or 'Maintained'.

Cc: Bob Feng <bob.c.feng@...>
Cc: Liming Gao <liming.gao@...>
Signed-off-by: Leif Lindholm <leif@...>
---
BaseTools/Scripts/GetMaintainer.py | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/BaseTools/Scripts/GetMaintainer.py b/BaseTools/Scripts/GetMaintainer.py
index fbc63522db77..2ec550e86d36 100644
--- a/BaseTools/Scripts/GetMaintainer.py
+++ b/BaseTools/Scripts/GetMaintainer.py
@@ -77,8 +77,12 @@ def get_section_maintainers(path, section):
matching the provided path in the provided section."""
maintainers = []
lists = []
+ nowarn_status = ['Supported', 'Maintained']

if path_in_section(path, section):
+ for status in section['status']:
+ if status not in nowarn_status:
+ print('WARNING: Maintained status for "%s" is \'%s\'!'
+ % (path, status))
for address in section['maintainer'], section['reviewer']:
# Convert to list if necessary
if isinstance(address, list):
--
2.20.1

Join devel@edk2.groups.io to automatically receive all group messages.