Re: [PATCH v1 0/3] Check if required ACPI tables are installed


Gao, Zhichao
 

For the patch set:
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

-----Original Message-----
From: Krzysztof Koch <Krzysztof.Koch@arm.com>
Sent: Tuesday, April 14, 2020 4:50 PM
To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
<zhichao.gao@intel.com>
Cc: Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini
<Matteo.Carlini@arm.com>; Laura Moretta <Laura.Moretta@arm.com>; nd
<nd@arm.com>
Subject: RE: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are
installed

Hi,

Can I get a review for this patch series?

Thanks,

Krzysztof

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
Krzysztof Koch via Groups.Io
Sent: Wednesday, March 25, 2020 9:39
To: devel@edk2.groups.io
Cc: ray.ni@intel.com; zhichao.gao@intel.com; Sami Mujawar
<Sami.Mujawar@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>;
Laura Moretta <Laura.Moretta@arm.com>; nd <nd@arm.com>
Subject: [edk2-devel] [PATCH v1 0/3] Check if required ACPI tables are
installed

This patch series adds a new capability to the Acpiview UEFI shell tool.
Using the -r command line parameter, it is now possible to choose a
specification which lists mandatory ACPI tables. The parameter value is then
consumed by a library which validates ACPI tables identified on the platform
against these requirements.

The -r parameter is architecture agnostic. However, as of now, the possible
values for the parameter are only defined in the context of the Arm
architecture.

For Arm-based platforms, it is now possible to validate that Server Base Boot
Requirements (SBBR) mandatory ACPI tables are present on the platform.

Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2/tree/617_sbbr_validate_acpi_tabl
e_counts_v1

Krzysztof Koch (3):
ShellPkg: acpiview: Add -r parameter for table requirements validation
ShellPkg: acpiview: Add library for SBBR ACPI requirements validation
ShellPkg: acpiview: Check if SBBR mandatory ACPI tables are installed

ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c |
16 ++
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 104
++++++++-
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.h | 44
+++-
ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.c
| 222 ++++++++++++++++++++
ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.h
| 91 ++++++++

ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman
dLib.inf | 6 +-

ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman
dLib.uni | 14 +-
7 files changed, 492 insertions(+), 5 deletions(-) create mode 100644
ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.c
create mode 100644
ShellPkg/Library/UefiShellAcpiViewCommandLib/Arm/SbbrValidator.h

--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


Join devel@edk2.groups.io to automatically receive all group messages.