Re: [edk2-platform][PATCH v1 1/3] Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe


Samer El-Haj-Mahmoud
 

Thanks Ard... Will take care of it next time.



From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Ard Biesheuvel via groups.io <ard.biesheuvel@...>
Sent: Saturday, April 11, 2020, 3:45 PM
To: Samer El-Haj-Mahmoud
Cc: edk2-devel-groups-io; Leif Lindholm; Pete Batard
Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/3] Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe

On Sat, 11 Apr 2020 at 17:56, Samer El-Haj-Mahmoud
<samer@...> wrote:
>
> Switch from the PI specific GraphicsConsoleDxe driver to the
> common driver in MdeModulePkg. There is no need to carry RPi specific
> version.
>
> This resolves https://github.com/pftf/RPi4/issues/32
>
> Cc: Leif Lindholm <leif@...>
> Cc: Ard Biesheuvel <ard.biesheuvel@...>
> Cc: Pete Batard <pete@...>
> Signed-off-by: Samer El-Haj-Mahmoud <samer@...>

Hi Samer,

Please use my @arm.com email address from now on.

Also, for future contributions, could you please include a cover
letter? It doesn't have to be elaborate if the changes are self
explanatory, but it helps disambiguate acks given against the whole
series.


> ---
>  Platform/RaspberryPi/RPi4/RPi4.dsc | 2 +-
>  Platform/RaspberryPi/RPi4/RPi4.fdf | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index 4fe4d810a0bc..785ac9b65633 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -582,7 +582,7 @@ [Components.common]
>
>    MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
>    MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
> -  Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
> +  MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
>    MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
>    MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
>    Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4/RPi4.fdf
> index a59d3b601a86..b21643639131 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.fdf
> +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf
> @@ -194,7 +194,7 @@ [FV.FvMain]
>    #
>    INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
>    INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
> -  INF Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
> +  INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
>    INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
>    INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
>    INF Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf
> --
> 2.17.1
>




IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Join devel@edk2.groups.io to automatically receive all group messages.