Re: [PATCH 1/1] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.3


Ard Biesheuvel
 

On Mon, 30 Mar 2020 at 15:12, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

On Mon, 30 Mar 2020 at 15:09, Pete Batard <pete@akeo.ie> wrote:

On 2020.03.30 14:06, Ard Biesheuvel wrote:
On Fri, 27 Mar 2020 at 14:06, Pete Batard <pete@akeo.ie> wrote:

Incidentally, this is not an [edk2-platform] patch, as the subject line
from previous mail seemed to indicate, but an [edk2] patch.
Do we have a user for this?
Yes we do. I have a pachset lined up that updates the Raspberry Pi ACPI
to 6.3, that has a dependency on this.
But does the RPi have SPE and the associated overflow interrupt? ACPI
is designed to be backward compatible, so it is perfectly acceptable
to use the 6.2 macros in the context of a firmware implementation that
complies with 6.3. Or is there another reason you want to update the
MADT to 6.3?
BTW, this patch sets the size of the GICC entry to 'sizeof
(EFI_ACPI_6_0_GIC_STRUCTURE)' so it is likely that the parser will
choke on it.

Join devel@edk2.groups.io to automatically receive all group messages.