Re: [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments


Zhang, Shenglei
 

Reviewed-by: Shenglei Zhang <shenglei.zhang@...>

-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
GuoMinJ
Sent: Thursday, March 5, 2020 2:41 PM
To: devel@edk2.groups.io
Cc: GuoMinJ <newexplorerj@...>; Wang, Jian J
<jian.j.wang@...>; Lu, XiaoyuX <xiaoyux.lu@...>
Subject: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi:
Add missing comments

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2552

DxeCryptLibConstructor have no comments for it, add comments for it.

Cc: Jian J Wang <jian.j.wang@...>
Cc: Xiaoyu Lu <xiaoyux.lu@...>
Signed-off-by: GuoMinJ <newexplorerj@...>
---
.../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
index 34d5f410b0..b503a5708b 100644
--- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
+++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c
@@ -32,6 +32,15 @@ GetCryptoServices (
return (VOID *)mCryptoProtocol;
}

+/**
+ Locate the valid Crypto Protocol.
+
+ @param ImageHandle The firmware allocated handle for the EFI image.
+ @param SystemTable A pointer to the EFI System Table.
+
+ @retval EFI_SUCCESS The constructor executed correctly.
+ @retval EFI_NOT_FOUND Found no valid Crypto Protocol.
+**/
EFI_STATUS
EFIAPI
DxeCryptLibConstructor (
--
2.17.1


Join devel@edk2.groups.io to automatically receive all group messages.