Re: [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

Nickle Wang

Hi Dandan,

Thanks for your reminder. I update my patch and it passed BaseTools/Scripts/ test.


-----Original Message-----
From: [] On Behalf Of Dandan Bi
Sent: Thursday, February 20, 2020 4:24 PM
To:; Wang, Nickle (HPS SW) <>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

Thanks Nickle for the fix.
One minor comment is that please pay attention to the format of commit message.
Refer to, Line length of commit message should be less than 76 characters when possible.
Please address it when submit the patch.
Reviewed-by: Dandan Bi <>


-----Original Message-----
From: [] On Behalf Of
Nickle Wang
Sent: Wednesday, February 19, 2020 10:23 PM
Cc: Bi, Dandan <>
Subject: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix
IsZeroGuid() ASSERT.

From the function description of GetIfrBinaryData(), FormSetGuid can
be NULL. However, FormSetGuid is passed to IsZeroGuid(). This causes
exception when FormSetGuid is NULL.

Signed-off-by: Nickle Wang <>
MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
index 288f1c3197..82067b541c 100644
--- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
@@ -2,6 +2,7 @@
Entry and initialization module for the browser.

Copyright (c) 2007 - 2018, Intel Corporation. All rights
+(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent

@@ -5844,7 +5845,7 @@ GetIfrBinaryData (
// Try to compare against formset GUID
- if (IsZeroGuid (FormSetGuid) ||
+ if (IsZeroGuid (ComparingGuid) ||
CompareGuid (ComparingGuid, (EFI_GUID *)(OpCodeData +

Join { to automatically receive all group messages.