Re: [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc.


Rebecca Cran
 

On 2020-02-09 12:07, Rebecca Cran wrote:
I recently got a HiFive Unleashed board, and am interested in trying out
RISCV EDK2 firmware either on it or in Qemu.

It looks like the opensbi submodule in
edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi needs updated
though: the commit currently used -
be92da280d87c38a2e0adc5d3f43bab7b5468f09 - is missing files such as
sbi_hfence.S mentioned in
RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf .

After updating the opensbi submodule to master, I now get a compile error:


/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:
In function 'sbi_ecall_find_extension':
/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:32:11:
error: implicit declaration of function 'container_of'
[-Werror=implicit-function-declaration]
  sbi_list_for_each_entry(t, &ecall_exts_list, head) {
           ^~~~~~~~~~~~
/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:32:50:
error: expected expression before 'typeof'
  sbi_list_for_each_entry(t, &ecall_exts_list, head) {
                                                  ^~~~
/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:32:132:
error: expected expression before 'typeof'
  sbi_list_for_each_entry(t, &ecall_exts_list, head) {
                                                                                                                                   
^
/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:
In function 'sbi_ecall_unregister_extension':
/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:64:50:
error: expected expression before 'typeof'
  sbi_list_for_each_entry(t, &ecall_exts_list, head) {
                                                  ^~~~
/home/bcran/workspace/edk2-staging/RiscVPkg/Library/RiscVOpensbiLib/opensbi/lib/sbi/sbi_ecall.c:64:132:
error: expected expression before 'typeof'
  sbi_list_for_each_entry(t, &ecall_exts_list, head) {
                                                                                                                                   
^
cc1: all warnings being treated as errors

--
Rebecca Cran

Join devel@edk2.groups.io to automatically receive all group messages.