Re: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues


Zeng, Star
 

Reviewed-by: Star Zeng <star.zeng@...>

-----Original Message-----
From: Chiu, Chasel <chasel.chiu@...>
Sent: Monday, February 10, 2020 11:53 AM
To: devel@edk2.groups.io
Cc: Ma, Maurice <maurice.ma@...>; Desimone, Nathaniel L
<@natedesimone>; Zeng, Star <star.zeng@...>
Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues

GenCfgOpt.py:
Issue was: invalid_operation: Invalid operation on null-like value "Base".
Fixed it by initializing Base to 0 before entering while loop.

SplitFspBin.py:
Issues were:
1. copy_paste_error: PeOptHdr vs PePlusOptHdr.
2. invalid_operation: Invalid operation on null-like value "roffset".
3. invalid_operation: Invalid operation on null-like value "rsize".
Fixed them by initializing roffset and rsize as PE32 image type and overriding
them when PE32+ header found.

Cc: Maurice Ma <maurice.ma@...>
Cc: Nate DeSimone <@natedesimone>
Cc: Star Zeng <star.zeng@...>
Signed-off-by: Chasel Chiu <chasel.chiu@...>

Chasel Chiu (2):
IntelFsp2Pkg/GenCfgOpt.py: Coverity scan flags issues.
IntelFsp2Pkg/SplitFspBin.py: Coverity scan flags issues.

IntelFsp2Pkg/Tools/GenCfgOpt.py | 3 ++-
IntelFsp2Pkg/Tools/SplitFspBin.py | 10 +++++-----
2 files changed, 7 insertions(+), 6 deletions(-)

--
2.13.3.windows.1

Join devel@edk2.groups.io to automatically receive all group messages.