Re: [PATCH 2/2] MdePkg: Use the same VA function for both CLANGPDB and CLANG38


Liming Gao
 

Reviewed-by: Liming Gao <liming.gao@...>

-----Original Message-----
From: Liu, Zhiguang <zhiguang.liu@...>
Sent: Monday, February 3, 2020 4:15 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@...>; Gao, Liming <liming.gao@...>
Subject: [PATCH 2/2] MdePkg: Use the same VA function for both CLANGPDB and CLANG38

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2415

For CLANGPDB tool chain and X64, use MS ABI version of GCC built-in macros for
variable argument lists to be align with CLANG38 tool chain.

Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Liming Gao <liming.gao@...>

Signed-off-by: Zhiguang Liu <zhiguang.liu@...>
---
MdePkg/Include/Base.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
index e0bcd0ae67..33211b96f7 100644
--- a/MdePkg/Include/Base.h
+++ b/MdePkg/Include/Base.h
@@ -623,7 +623,7 @@ typedef char* VA_LIST;

#elif defined(__GNUC__) || defined(__clang__)

-#if defined(MDE_CPU_X64) && !defined(NO_MSABI_VA_FUNCS) && !defined(__clang__)
+#if defined(MDE_CPU_X64) && !defined(NO_MSABI_VA_FUNCS)
//
// X64 only. Use MS ABI version of GCC built-in macros for variable argument lists.
//
--
2.16.2.windows.1

Join devel@edk2.groups.io to automatically receive all group messages.