Re: [PATCH] Add support for FuSA ACM in FitGen tool


Agrawal, Sachin
 

I am working with FitGen specification owner to update the spec and include FuSa ACM type entry and get it published.

Thanks
Sachin

-----Original Message-----
From: Gao, Liming
Sent: Monday, October 14, 2019 5:24 PM
To: Agrawal, Sachin <sachin.agrawal@intel.com>; devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>
Subject: RE: [PATCH] Add support for FuSA ACM in FitGen tool

As you know, FitGen is used to generate firmware interface table. This table is defined in public specification.

Can you let me whether this new entry is defined in the latest FitGen spec?

Thanks
Liming
-----Original Message-----
From: Agrawal, Sachin
Sent: Tuesday, October 15, 2019 7:24 AM
To: devel@edk2.groups.io
Cc: Agrawal, Sachin <sachin.agrawal@intel.com>; Feng, Bob C
<bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [PATCH] Add support for FuSA ACM in FitGen tool

REF https://bugzilla.tianocore.org/show_bug.cgi?id=2200

FitGen Tool is responsible for creating FIT table in UEFI BIOS.
A new FIT entry type (FIT Type 0x3) has been allocated for FuSa ACM.
FitGen tool is updated to add support for this FuSa ACM.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>

Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
---
Silicon/Intel/Tools/FitGen/FitGen.c | 82
+++++++++++++++++++++++++++++++++++++
1 file changed, 82 insertions(+)

diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c
b/Silicon/Intel/Tools/FitGen/FitGen.c
index faf9880060..1ebce40505 100644
--- a/Silicon/Intel/Tools/FitGen/FitGen.c
+++ b/Silicon/Intel/Tools/FitGen/FitGen.c
@@ -217,6 +217,7 @@ typedef struct {
#define FIT_TABLE_TYPE_HEADER 0
#define FIT_TABLE_TYPE_MICROCODE 1
#define FIT_TABLE_TYPE_STARTUP_ACM 2
+#define FIT_TABLE_TYPE_FUSA_ACM 3
#define FIT_TABLE_TYPE_BIOS_MODULE 7
#define FIT_TABLE_TYPE_TPM_POLICY 8
#define FIT_TABLE_TYPE_BIOS_POLICY 9
@@ -246,6 +247,8 @@ typedef struct {
UINT32 FitHeaderVersion;
FIT_TABLE_CONTEXT_ENTRY StartupAcm;
UINT32 StartupAcmVersion;
+ FIT_TABLE_CONTEXT_ENTRY FusaAcm;
+ UINT32 FusaAcmVersion;
FIT_TABLE_CONTEXT_ENTRY BiosModule[MAX_BIOS_MODULE_ENTRY];
UINT32 BiosModuleVersion;
FIT_TABLE_CONTEXT_ENTRY Microcode[MAX_MICROCODE_ENTRY];
@@ -317,6 +320,7 @@ Returns:
"\t[-CLEAR]\n"
"\t[-I <BiosInfoGuid>]\n"
"\t[-S <StartupAcmAddress StartupAcmSize>|<StartupAcmGuid>]

Join devel@edk2.groups.io to automatically receive all group messages.