Re: [PATCH] BaseTools X64: fold PLT relocations into simple relative references


Ard Biesheuvel
 

On 4 August 2016 at 10:58, Shi, Steven <steven.shi@intel.com> wrote:
OK, it is. But it is a bit not very clear.
Did you read the elaborate comment block explaining that (and why) it
is appropriate to treat R_X86_64_PLT32 as a R_X86_64_PC32 relocation?
This is not generally true, but it is true for UEFI since we don't
support shared libraries.

So I think it is incorrect to simply duplicate the code for
R_X86_64_PC32 without mentioning that, and suggesting that the PLT
relocation receive some kind of treatment that is different.

Thanks,
Ard.

Join devel@edk2.groups.io to automatically receive all group messages.