Re: [PATCH] BaseTools X64: fold PLT relocations into simple relative references


Shi, Steven <steven.shi@...>
 

OK, it is. But it is a bit not very clear.





Steven Shi

Intel\SSG\STO\UEFI Firmware



Tel: +86 021-61166522

iNet: 821-6522

-----Original Message-----
From: Ard Biesheuvel [mailto:ard.biesheuvel@...]
Sent: Thursday, August 04, 2016 4:55 PM
To: Shi, Steven <steven.shi@...>
Cc: Zhu, Yonghong <yonghong.zhu@...>; Gao, Liming
<liming.gao@...>; Justen, Jordan L <jordan.l.justen@...>;
edk2-devel@...; mischief@...
Subject: Re: [PATCH] BaseTools X64: fold PLT relocations into simple relative
references
On 4 August 2016 at 10:54, Shi, Steven <steven.shi@...<mailto:steven.shi@...>> wrote:
Hi Ard,
I don't see you add below code for case R_X86_64_PLT32. Is it right?
*(UINT32 *)Targ = (UINT32) (*(UINT32 *)Targ
+ (mCoffSectionsOffset[Sym->st_shndx] - SymShdr->sh_addr)
- (SecOffset - SecShdr->sh_addr));
Isn't it identical to the code for R_X86_64_PC32?

Join devel@edk2.groups.io to automatically receive all group messages.