[PATCH 12/35] MdeModulePkg: stop abusing EFI_HANDLE for keystroke notify registration


Laszlo Ersek
 

EFI_REGISTER_KEYSTROKE_NOTIFY and EFI_UNREGISTER_KEYSTROKE_NOTIFY require
the notification handle to have type (VOID*). The notification handle has
nothing to do with the EFI_HANDLE type.

This change is a semantic fix; functionally, it's a no-op.

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---

Notes:
lightly tested: ConSplitterDxe is part of the ArmVirt and OVMF platfo=
rms

MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +-
MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c =
b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
index 63c814ae1816..9c38271b65f9 100644
--- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
+++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
@@ -4026,7 +4026,7 @@ ConSplitterTextInRegisterKeyNotify (
if (NewNotify =3D=3D NULL) {
return EFI_OUT_OF_RESOURCES;
}
- NewNotify->NotifyHandleList =3D (EFI_HANDLE *) AllocateZeroPool (sizeo=
f (EFI_HANDLE) * Private->TextInExListCount);
+ NewNotify->NotifyHandleList =3D (VOID **) AllocateZeroPool (sizeof (VO=
ID *) * Private->TextInExListCount);
if (NewNotify->NotifyHandleList =3D=3D NULL) {
gBS->FreePool (NewNotify);
return EFI_OUT_OF_RESOURCES;
diff --git a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c b/MdeM=
odulePkg/Universal/DriverSampleDxe/DriverSample.c
index 7cfd5c178861..f98797225b63 100644
--- a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c
+++ b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c
@@ -143,7 +143,7 @@ InternalStartMonitor(
EFI_HANDLE *Handles;
UINTN HandleCount;
UINTN HandleIndex;
- EFI_HANDLE NotifyHandle;
+ VOID *NotifyHandle;
=20
Status =3D gBS->LocateHandleBuffer (
ByProtocol,
@@ -202,7 +202,7 @@ InternalStopMonitor(
EFI_KEY_DATA KeyData;
UINTN HandleCount;
UINTN HandleIndex;
- EFI_HANDLE NotifyHandle;
+ VOID *NotifyHandle;
=20
Status =3D gBS->LocateHandleBuffer (
ByProtocol,
--=20
2.19.1.3.g30247aa5d201

Join devel@edk2.groups.io to automatically receive all group messages.