- [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types
Re: [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types
toggle quoted messageShow quoted text
From: Leif Lindholm [mailto:email@example.com]
Sent: Tuesday, September 17, 2019 5:15 PM
To: firstname.lastname@example.org; Zhang, Shenglei <email@example.com>
Cc: firstname.lastname@example.org; Wang, Jian J <email@example.com>; Wu, Hao A <firstname.lastname@example.org>; Ni, Ray <email@example.com>;
Laszlo Ersek <firstname.lastname@example.org>; Gao, Liming <email@example.com>; Gao, Zhichao <firstname.lastname@example.org>
Subject: Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types
On Tue, Sep 17, 2019 at 07:17:27AM +0000, Zhang, Shenglei wrote:
That's my mistake to push the broken patch(0d85e67714e31e0dbe4241ab2ebb7c423aba174d).Determining what affects build and not is something humans are very
This patch only updates the file guid, which I thought has no risk. So I didn’t check the build result.
I should double check the new guid used in the file.
bad at and computers are very good at.
So you should build check every patch you submit to the list, no
matter how trivial.
In normal circumstances, so should the maintainers before pushing the
I push this change. I should double confirm its test result. I will improve my rule.
We now have a commit in the tree known to break the build of pretty
much all ARM/AARCH64 platforms. This will be very unpleasant for
I agree the build break is the big impact. I expect we can speed up to enable EDK II Continuous Integration.
If so, we can avoid such break again.
Join email@example.com to automatically receive all group messages.