Re: [PATCH V2 00/10] Multiple Controllers Support solution


Liming Gao
 

Eric:
I push the change for edk2platform.
And, I push the remaining patches a6ee24fbddcd901347014e045611eb6108f4f741..a5944b6a13e227da23daa0ab59b5d6f4b06bb49b

Thanks
Liming

-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
Liming Gao
Sent: Wednesday, August 14, 2019 12:38 PM
To: Jin, Eric <eric.jin@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support
solution

Eric:
I push the first 3 patches
82407bd129dca8ec6d96e85f541b0974c8d7e087..1f06aa24c29405f271f514f01c3
96c2ba19c1370.
Then, the changes in edk2 platform can be submitted. After edk2platform
change is ready, I will push the remaining patch set.

Thanks
Liming
-----Original Message-----
From: Jin, Eric
Sent: Monday, August 12, 2019 11:17 PM
To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
Cc: Jin, Eric <eric.jin@intel.com>
Subject: RE: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support
solution

Liming,

Thank you for comment.
We will update GetLowestSupportedVersion() API function header to
include
Private param when we push the code to repo. Thanks.

Best Regards
Eric

-----Original Message-----
From: Gao, Liming
Sent: Monday, August 12, 2019 5:24 PM
To: Jin, Eric <eric.jin@intel.com>; devel@edk2.groups.io
Subject: RE: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support
solution

That's good information.

In patch 5, GetLowestSupportedVersion() API function header should be
updated to include Private param. I have no other comments.

With this change, Reviewed-by: Liming Gao <liming.gao@intel.com>

///
@@ -193,7 +200,7 @@ GetImageTypeNameString ( **/
UINT32
GetLowestSupportedVersion (
- VOID
+ FIRMWARE_MANAGEMENT_PRIVATE_DATA *Private
)

Thanks
Liming
-----Original Message-----
From: Jin, Eric
Sent: Monday, August 12, 2019 3:14 PM
To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
Subject: RE: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support
solution

Liming,

The differences between V2 and V1 are listed below.

1) The series is composed of 10 patches in V2 (14 in V1). patch 14 is
merged into patch 4, and patch 11/12/13 are merged into patch 5.
2) Try to fix the issue exposed by ECC.

Btw, the patch of edk2-platform
Platform\Intel\Vlv2TbltDevicePkg\Feature\Capsule\Library\FmpDeviceLib
to support new APIs is provided in separated patch
https://edk2.groups.io/g/devel/message/45328

Best Regards
Eric

-----Original Message-----
From: Gao, Liming
Sent: Monday, August 12, 2019 1:19 PM
To: devel@edk2.groups.io; Jin, Eric <eric.jin@intel.com>
Subject: RE: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support
solution

Eric:
Can you list the difference compared to version 1?

Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
Eric Jin
Sent: Monday, August 12, 2019 9:46 AM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support
solution

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525

The patch set is to support drivers that manage multiple controllers
and also provide a firmware update capability to each managed controller.

The following modules are related to Multiple Controllers Support
solution

FmpDevicePkg\FmpDxe\FmpDxe.inf - Driver to manage multiple
controllers
and provide the firmware update capability to each managed controller.
FmpDevicePkg\CapsuleUpdatePolicyDxe\CapsuleUpdatePolicyDxe.inf -
Driver
to produce the Capsule Update Policy Protocol using the services of
the CapsuleUpdatePolicyLib class. The protocol is a private interface
to the FmpDevicePkg
FmpDevicePkg\Library\CapsuleUpdatePolicyLibOnProtocol\CapsuleUpdat
e
P
o
licyLibOnProtocol.inf -
CapsuleUpdatePolicyLib instance that uses the services of the Capsule
Update Policy Protocol produced by CapsuleUpdatePolicyDxe
FmpDevicePkg\Library\CapsuleUpdatePolicyLibNull\CapsuleUpdatePolicy
Li
b
N
ull.inf -
Null CapsuleUpdatePolicyLib instance and the template for platform
specific implementation
FmpDevicePkg\Library\FmpDeviceLibNull\FmpDeviceLibNull.inf - Null
FmpDeviceLib instance and the template for platform specific
implementation

Eric Jin (10):
FmpDevicePkg: Add UEFI_DRIVER support
FmpDevicePkg: Add APIs to FmpDeviceLib
FmpDEvicePkg/FmpDeviceLibNull: Implement new APIs
FmpDevicePkg/FmpDxe: Use new FmpDeviceLib APIs
FmpDevicePkg/FmpDxe: Different variable for each FMP Descriptor
FmpDevicePkg: Add Capsule Update Policy Protocol
FmpDevicePkg/FmpDxe: Improve all DEBUG() messages
FmpDevicePkg/FmpDxe: Add PcdFmpDeviceImageTypeIdGuid
FmpDevicePkg/FmpDxe: Add PcdFmpDeviceStorageAccessEnable
FmpDevicePkg/FmpDxe: Remove use of CatSprint()

.../CapsuleUpdatePolicyDxe.c | 173 ++++
.../CapsuleUpdatePolicyDxe.h | 140 +++
.../CapsuleUpdatePolicyDxe.inf | 48 +
.../CapsuleUpdatePolicyDxe.uni | 14 +
.../CapsuleUpdatePolicyDxeExtra.uni | 14 +
FmpDevicePkg/FmpDevicePkg.dec | 43 +-
FmpDevicePkg/FmpDevicePkg.dsc | 64 +-
FmpDevicePkg/FmpDevicePkg.uni | 16 +-
FmpDevicePkg/FmpDxe/DetectTestKey.c | 16 +-
FmpDevicePkg/FmpDxe/FmpDxe.c | 792 ++++++++++------
FmpDevicePkg/FmpDxe/FmpDxe.h | 355 ++++++++
FmpDevicePkg/FmpDxe/FmpDxe.inf | 7 +-
FmpDevicePkg/FmpDxe/FmpDxeLib.inf | 7 +-
FmpDevicePkg/FmpDxe/VariableSupport.c | 844 +++++++++++++----
-
FmpDevicePkg/FmpDxe/VariableSupport.h | 135 ++-
FmpDevicePkg/Include/Library/FmpDeviceLib.h | 104 ++-
.../CapsuleUpdatePolicyLibOnProtocol.c | 171 ++++
.../CapsuleUpdatePolicyLibOnProtocol.inf | 40 +
.../CapsuleUpdatePolicyLibOnProtocol.uni | 15 +
.../Library/FmpDeviceLibNull/FmpDeviceLib.c | 93 +-
.../FmpDeviceLibNull/FmpDeviceLibNull.inf | 4 +-
.../FmpPayloadHeaderLibV1.inf | 4 +-
.../Library/FmpPayloadHeaderLib.h | 0
.../Protocol/CapsuleUpdatePolicy.h | 132 +++
24 files changed, 2644 insertions(+), 587 deletions(-) create mode
100644
FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.c
create mode 100644
FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.h
create mode 100644
FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.inf
create mode 100644
FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.uni
create mode 100644
FmpDevicePkg/CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxeExtra.u
n
i
create mode 100644 FmpDevicePkg/FmpDxe/FmpDxe.h create mode
100644
FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdat
e
P
o
licyLibOnProtocol.c
create mode 100644
FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdat
e
P
o
licyLibOnProtocol.inf
create mode 100644
FmpDevicePkg/Library/CapsuleUpdatePolicyLibOnProtocol/CapsuleUpdat
e
P
o
licyLibOnProtocol.uni
rename FmpDevicePkg/{Include =>
PrivateInclude}/Library/FmpPayloadHeaderLib.h (100%) create mode
100644 FmpDevicePkg/PrivateInclude/Protocol/CapsuleUpdatePolicy.h

--
2.20.1.windows.1



Join devel@edk2.groups.io to automatically receive all group messages.