Re: [PATCH v2 0/3] add DwMmcHcDxe driver


Loh, Tien Hock
 

Hi Leif, Ard, Christopher,

Haojian and I have tested the driver on 2 platforms, any further comments on this?

Thanks
Tien Hock

-----Original Message-----
From: Haojian Zhuang <haojian.zhuang@linaro.org>
Sent: Tuesday, July 30, 2019 3:33 PM
To: Loh, Tien Hock <tien.hock.loh@intel.com>; leif.lindholm@linaro.org;
ard.biesheuvel@linaro.org; christopher.Co@microsoft.com
Cc: devel@edk2.groups.io; thloh85@gmail.com
Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver

On Wed, Jul 24, 2019 at 05:26:03PM +0800, tien.hock.loh@intel.com wrote:
From: "Tien Hock, Loh" <tien.hock.loh@intel.com>

Changelog:
v3:
* Fix an issue in NonDiscoverableDeviceDxe driver where it did not
invalidate
cache before copying the memory.
v2:
*Split DwMmcHcDxe driver into two patches. One is for PlatformDwMmc
protocol,
and the other is for DwMmcHcDxe driver.
v1:
*Add NonDiscoverableDeviceDxe for embedded platform. Make
DwMmcHcDxe driver
to support both eMMC and SD controller.

Haojian Zhuang (3):
EmbeddedPkg: add NonDiscoverableDeviceDxe driver
EmbeddedPkg: add PlatformDwMmc protocol
EmbeddedPkg/Drivers: add DwMmcHcDxe driver

.../Drivers/DwMmcHcDxe/ComponentName.c | 214 ++
EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c | 1295
+++++++++
EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec | 40 +
EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h | 815 ++++++
EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf | 69 +
EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c | 2366
+++++++++++++++++
EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h | 983 +++++++
EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c | 1042 ++++++++
EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c | 1104 ++++++++
EmbeddedPkg/EmbeddedPkg.dec | 1 +
EmbeddedPkg/Include/Protocol/PlatformDwMmc.h | 79 +
.../NonDiscoverableDeviceDxe/ComponentName.c | 124 +
.../NonDiscoverableDeviceDxe.c | 243 ++
.../NonDiscoverableDeviceDxe.inf | 52 +
.../NonDiscoverableDeviceIo.c | 976 +++++++
.../NonDiscoverableDeviceIo.h | 92 +
16 files changed, 9495 insertions(+)
create mode 100644
EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c
create mode 100644
EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c
create mode 100644
EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec
create mode 100644
EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h
create mode 100644
EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf
create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c
create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h
create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c
create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c
create mode 100644 EmbeddedPkg/Include/Protocol/PlatformDwMmc.h
create mode 100644
EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c
create mode 100644
EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
eDx
e.c create mode 100644
EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
eDx
e.inf create mode 100644
EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
eIo
.c create mode 100644
EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic
eIo
.h

--
2.19.0
Hi Leif, Ard & Chris,

Could you help to share your comments on this patch set?

Best Regards
Haojian

Join devel@edk2.groups.io to automatically receive all group messages.