Re: [PATCH 0/2] Put AP into safe hlt-loop code on S3 path
Fan, Jeff <jeff.fan@...>
Paolo,toggle quoted message Show quoted text
I added patch #3 in v2 to do InterlockedDecrement (&mNumberToFinish) in the safe code.
This is very good comment to eliminate this gap.
From: Paolo Bonzini [mailto:paolo.bonzini@...] On Behalf Of Paolo Bonzini
Sent: Thursday, November 10, 2016 5:59 PM
To: Fan, Jeff; edk2-devel@...
Subject: Re: [edk2] [PATCH 0/2] Put AP into safe hlt-loop code on S3 path
On 10/11/2016 07:07, Jeff Fan wrote:
On S3 path, we will wake up APs to restore CPU context inReviewed-by: Paolo Bonzini <pbonzini@...>
It would be slightly more robust to do the "InterlockedDecrement (&mNumberToFinish);" while in safe state, but the race window is really really small.