Re: [PATCH v1 0/1] Added GOP driver for DisplayLink-based Universal USB Docks to edk2-platforms
|
Leif Lindholm
Hi Andy,
toggle quoted messageShow quoted text
Many thanks for this submission. I am finding a few issues when building with gcc/clang (I expect you use Visual Studio). The RELEASE target barfs with .../edk2-platforms/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Gop.c:363:1: error: unused function 'CalculateRefreshRate' since the function is only called from a DEBUG statement. Could be resolved by putting the function inside #ifndef MDEPKG_NDEBUG Clang triggers an error on the USB_DISPLAYLINK_DEV_FROM_GRAPHICS_OUTPUT_PROTOCOL macro which seems to go away if the USB_DISPLAYLINK_DEV_SIGNATURE macro is moved below the USB_DISPLAYLINK_DEV definition. (I haven't bothered to figure out why this helps.) The NOOPT build fails for IA32/X64 on clang with .../edk2-platforms/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDescriptors.c:35: undefined reference to `memset' You could get rid of this by doing the assignment separate from the definition. (Indeed, I believe this is one of the reasons for the rule.) On X64/clang, the build fails with .../edk2-platforms/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbDisplayLink.c:410:3: error: '__builtin_ms_va_start' used in System V ABI function Adding EFIAPI to the definition/declaration of DlGopPrintTextToScreen makes this one go away. Best Regards, Leif
On Wed, Aug 14, 2019 at 02:43:43PM +0000, Andy Hayes wrote:
From 4a42eb997aeb3699217b40bf3bc47dec56458847 Mon Sep 17 00:00:00 2001
|
|
|