Note: groups.io will be down for maintenance this evening, starting at 11pm Pacific Time (6am Tuesday 8/3/2020 UTC), for up to two hours.
Re: [PATCH v4 20/35] OvmfPkg/XenPlatformPei: Introduce XenPvhDetected
Roger Pau Monné
On Mon, Jul 29, 2019 at 04:39:29PM +0100, Anthony PERARD wrote:
XenPvhDetected() can be used to figure out if OVMF has started via theThanks, I've got a comment, but it can be fixed afterwards if required.
---That's IMO dangerous. Using the version as an indication that
XenConnect has run seems like a bad idea, since returning a major
version of 0 is a valid number to return. Can't you check against
something else that doesn't depends on hypervisor provided data? (ie:
like some allocations or such that happen in XenConnect)
A paranoid could provider could even return major == 0 and minor == 0
in order to attempt to hide the Xen version used, since guests are not
supposed to infer anything from the Xen version, available hypervisor
features are reported by other means.