Re: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation


Krzysztof Koch
 

Hi Jaben and Ray,

It's been a while since I posted this patch. Can I help you in any way to get this merged?

Kind regards,

Krzysztof Koch

-----Original Message-----
From: Sami Mujawar <Sami.Mujawar@arm.com>
Sent: Thursday, May 9, 2019 14:37
To: devel@edk2.groups.io
Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd <nd@arm.com>; Krzysztof Koch <Krzysztof.Koch@arm.com>
Subject: RE: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

-----Original Message-----
From: Krzysztof Koch <krzysztof.koch@arm.com>
Sent: 31 January 2019 01:30 PM
To: edk2-devel@lists.01.org
Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini <Matteo.Carlini@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; nd <nd@arm.com>
Subject: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation

Removed conditional pre-compiling for ARM CPUs because function
ValidateCacheAttributes(..) is based on ACPI PPTT specification.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
Reported-by: Zhichao Gao <zhichao.gao@intel.com>
---

The code can be found at:
https://github.com/KrzysztofKoch1/edk2/tree/woa_422_cache_valid_fix_v1

Notes:
v1:
- removed conditional precompilation [Krzysztof]

ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
index bc56fe9ea1dd9c1e98a6a568d3f9191263bedc90..b6b420890a3494869020ed8bcc7b791fcf7d70f3 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c
@@ -86,11 +86,9 @@ ValidateCacheAttributes (
IN VOID* Context
)
{
-#if defined(MDE_CPU_ARM) || defined (MDE_CPU_AARCH64)
// Reference: Advanced Configuration and Power Interface (ACPI) Specification
// Version 6.2 Errata A, September 2017
// Table 5-153: Cache Type Structure
-
UINT8 Attributes;
Attributes = *(UINT8*)Ptr;

@@ -102,7 +100,6 @@ ValidateCacheAttributes (
);
return;
}
-#endif
}

/**
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Join devel@edk2.groups.io to automatically receive all group messages.