Re: [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode


Liming Gao
 

Ard:
My GNU ld (GNU Binutils for Ubuntu) 2.24. Which version you use?

1. #pragma GCC visibility push (hidden) , GCC5 with GCC49 tool chain pass. GCC5 with GCC5 tool chain failure. Here is failure message.
GenFw: Elf64Convert.c:424: ScanSections64: Assertion `((BOOLEAN)(0==1))' failed.
GenFw: ERROR 3000: Invalid
Did not find any '.text' section.
Aborted (core dumped)

2. #pragma GCC visibility push (protected), GCC5 with GCC49 tool chain failure, GCC5 with GCC5 tool chain pass. Failure message is below.

Thanks
Liming

-----Original Message-----
From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
Sent: Monday, August 01, 2016 3:04 AM
To: Gao, Liming <liming.gao@intel.com>
Cc: edk2-devel@lists.01.org; lersek@redhat.com; Shi, Steven
<steven.shi@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>; Justen,
Jordan L <jordan.l.justen@intel.com>; leif.lindholm@linaro.org
Subject: Re: [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode

On 30 July 2016 at 16:34, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
On 29 July 2016 at 17:18, Gao, Liming <liming.gao@intel.com> wrote:
Ard:

My gcc version 5.3.0 20151204 (Ubuntu 5.3.0-3ubuntu1~14.04). I will try
GCC54.
I cannot reproduce this with 5.3.1-14ubuntu2.1 either.
@Liming: is the issue still reproducible with this change?

"""
diff --git a/MdePkg/Include/X64/ProcessorBind.h
b/MdePkg/Include/X64/ProcessorBind.h
index a4aad3e..73cf799 100644
--- a/MdePkg/Include/X64/ProcessorBind.h
+++ b/MdePkg/Include/X64/ProcessorBind.h
@@ -34,7 +34,7 @@
// symbols directly using relative references rather than via the GOT, which
// contains absolute symbol addresses that are subject to runtime relocation.
//
-#pragma GCC visibility push (protected)
+#pragma GCC visibility push (hidden)
#endif

#if defined(__INTEL_COMPILER)
"""

Thanks,
Ard.

Join devel@edk2.groups.io to automatically receive all group messages.