On 29 July 2016 at 22:33, Jordan Justen <firstname.lastname@example.org> wrote:
On 2016-07-28 23:09:15, Ard Biesheuvel wrote:OK, so you are not seeing the issue Liming reported when using theOn 29 July 2016 at 06:47, Gao, Liming <email@example.com> wrote:I tested GCC44 (X64) on an old live-cd where GCC 4.4 was the supportedArd:Yes, I tested all of them.
GCC49 toolchain tag with GCC 5.4?
In that case, I am inclined to diagnose Liming's issue as a GCC 5.x
regression that was fixed in 5.4. Adding the GOT handling to GenFw
would still be possible, of course, but GOT based symbol references
are sub-optimal so we should try to avoid them imo. If GCC 4.x does
not emit any such references with protected visibility enabled, and
nor does GCC 5.4, I think it it reasonable to require that GCC 5.3
users simply use the GCC5 profile (with LTO), and switch to either 4.9
or 5.4 if they want to use the GCC49 profile instead.
Can you add something like 'added GCC5 toolchain' into the subject forOf course, that makes sense.
3, 4 & 7 Reviewed-by: Jordan Justen <firstname.lastname@example.org>Thanks,