Date
1 - 1 of 1
[Bug 4319] MdePkg/Library/BasePrintLib: Coverity scan flags MISSING_BREAK issue
bugzilla-daemon@...
https://bugzilla.tianocore.org/show_bug.cgi?id=4319
--- Comment #1 from Veeresh Sangolli <veeresh.sangolli@...> ---
Created attachment 1310
--> https://bugzilla.tianocore.org/attachment.cgi?id=1310&action=edit
Proposed patch to resolve the Missing_Break issue pointed by Coverity for
MdePkg
The function BasePrintLibSPrintMarker has a switch-case on variable
FormatCharacter in which
case '0': falls through to
case '1':
While this may be intentional, it is not evident to any general code
reader as well as any static analyzer tool. Just adding
// No break; here as this is an intentional fallthrough.
as comment in between makes any reader as well as Coverity happy.
--
You are receiving this mail because:
You are on the CC list for the bug.
--- Comment #1 from Veeresh Sangolli <veeresh.sangolli@...> ---
Created attachment 1310
--> https://bugzilla.tianocore.org/attachment.cgi?id=1310&action=edit
Proposed patch to resolve the Missing_Break issue pointed by Coverity for
MdePkg
The function BasePrintLibSPrintMarker has a switch-case on variable
FormatCharacter in which
case '0': falls through to
case '1':
While this may be intentional, it is not evident to any general code
reader as well as any static analyzer tool. Just adding
// No break; here as this is an intentional fallthrough.
as comment in between makes any reader as well as Coverity happy.
--
You are receiving this mail because:
You are on the CC list for the bug.