[EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005
I create PR https://github.com/tianocore/edk2/pull/644 for this patch.
From: Bret Barkelew <Bret.Barkelew@...>
Sent: Wednesday, May 27, 2020 6:11 AM
To: Laszlo Ersek <lersek@...>; email@example.com; Gao, Liming <liming.gao@...>; firstname.lastname@example.org
Cc: Leif Lindholm <leif@...>; afish@...; Kinney, Michael D <michael.d.kinney@...>
Subject: Re: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005
I just looked into it, and I think that AsciiStrCpyS() was the wrong function to call in this loop anyway. AsciiStrCpyS() will fail without copying any characters.
AsciiStrnCpyS() will perform the string "slicing"/"chunking" that the loop seems to expect.
The bug stands and we should try to get that bug fix into the stable tag. Thanks!
From: Laszlo Ersek <lersek@...<mailto:lersek@...>>
Sent: Monday, May 25, 2020 10:46 AM
To: Bret Barkelew <Bret.Barkelew@...<mailto:Bret.Barkelew@...>>; email@example.com<mailto:firstname.lastname@example.org> <email@example.com<mailto:firstname.lastname@example.org>>; liming.gao <liming.gao@...<mailto:liming.gao@...>>; email@example.com<mailto:firstname.lastname@example.org> <email@example.com<mailto:firstname.lastname@example.org>>
Cc: Leif Lindholm <leif@...<mailto:leif@...>>; afish@...<mailto:afish@...> <afish@...<mailto:afish@...>>; Kinney, Michael D <michael.d.kinney@...<mailto:michael.d.kinney@...>>
Subject: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005
On 05/22/20 17:11, Bret Barkelew wrote:
We'd like to ask that this patch be considered for the stable tag:does the original issue (reported in TianoCore#2721) persist with
My understanding (from TianoCore#2721) is that the original
AsciiStrCpyS() call is not buggy, it just triggers a (per spec) error
condition in AsciiStrCpyS(). Previously, that would indeed trip an
ASSERT(), but AIUI that issue has been resolved generally with
If the AsciiStrCpyS() call remains an issue with the ASSERT() removed,
then replacing the call with AsciiStrnCpyS() still seems like a bugfix
to me, not a "feature", so I think the patch is eligible for merging
during the HFF.
Mike, can you please merge the patch (if it's still needed)?