[EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005


Liming Gao
 

I create PR https://github.com/tianocore/edk2/pull/644 for this patch.

Thanks
Liming
From: Bret Barkelew <Bret.Barkelew@microsoft.com>
Sent: Wednesday, May 27, 2020 6:11 AM
To: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; announce@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>; afish@apple.com; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005

I just looked into it, and I think that AsciiStrCpyS() was the wrong function to call in this loop anyway. AsciiStrCpyS() will fail without copying any characters.
AsciiStrnCpyS() will perform the string "slicing"/"chunking" that the loop seems to expect.

The bug stands and we should try to get that bug fix into the stable tag. Thanks!


- Bret

________________________________
From: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>
Sent: Monday, May 25, 2020 10:46 AM
To: Bret Barkelew <Bret.Barkelew@microsoft.com<mailto:Bret.Barkelew@microsoft.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; liming.gao <liming.gao@intel.com<mailto:liming.gao@intel.com>>; announce@edk2.groups.io<mailto:announce@edk2.groups.io> <announce@edk2.groups.io<mailto:announce@edk2.groups.io>>
Cc: Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; afish@apple.com<mailto:afish@apple.com> <afish@apple.com<mailto:afish@apple.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Subject: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005

Hi Bret,

On 05/22/20 17:11, Bret Barkelew wrote:
We'd like to ask that this patch be considered for the stable tag:
[PATCH v1 1/1] UnitTestFrameworkPkg/UnitTestResultReportLib: Use AsciiStrnCpyS()
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2721&;data=02%7C01%7Cbret.barkelew%40microsoft.com%7C2698d0e553c04b47194c08d800d398b8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637260256091133309&amp;sdata=MDKQ1CKq9%2B9AfPML0JxcND47UIcQUAibUSAVlfW5iZc%3D&amp;reserved=0

The patch was reviewed prior to the hard freeze date, and is a small change that affects new(ish) code that is not heavily utilized yet.
does the original issue (reported in TianoCore#2721) persist with
TianoCore#2054 fixed?

My understanding (from TianoCore#2721) is that the original
AsciiStrCpyS() call is not buggy, it just triggers a (per spec) error
condition in AsciiStrCpyS(). Previously, that would indeed trip an
ASSERT(), but AIUI that issue has been resolved generally with
TianoCore#2054.

If the AsciiStrCpyS() call remains an issue with the ASSERT() removed,
then replacing the call with AsciiStrnCpyS() still seems like a bugfix
to me, not a "feature", so I think the patch is eligible for merging
during the HFF.

Mike, can you please merge the patch (if it's still needed)?

Thanks
Laszlo



- Bret

From: Liming Gao via groups.io<mailto:liming.gao=intel.com@groups.io>
Sent: Friday, May 22, 2020 1:01 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io<mailto:devel@edk2.groups.io%3cmailto:devel@edk2.groups.io>>; announce@edk2.groups.io<mailto:announce@edk2.groups.io<mailto:announce@edk2.groups.io%3cmailto:announce@edk2.groups.io>>
Cc: Laszlo Ersek<mailto:lersek@redhat.com>; Leif Lindholm<mailto:leif@nuviainc.com>; afish@apple.com<mailto:afish@apple.com>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>
Subject: [EXTERNAL] [edk2-devel] Hard Feature Freeze starts now for edk2-stable202005

Hi, all
Today, we enter into Hard Feature Freeze phase until edk2-stable202005 tag is created at 2020-05-29. In this phase, there is no feature to be pushed. The critical bug fix is still allowed.

If the patch is sent after Hard Feature Freeze, and plans to catch this stable tag, please add edk2-stable202005 key words in the patch title and BZ, and also cc to Tianocore Stewards, then Stewards can give the comments.

Below is edk2-stable202005 tag planning.
Date (00:00:00 UTC-8) Description
2020-03-04 Beginning of development
2020-05-08 Feature Planning Freeze
2020-05-15 Soft Feature Freeze
2020-05-22 Hard Feature Freeze
2020-05-29 Release

Thanks
Liming